GHSA-4VFC-HXPJ-F7X7
RTSP credentials leak to viewer role via nginx proxy_cache
Texto original en inglés · Ver en español
CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:N/A:N
Fuente: GitHub
Ciclo de vida de la vulnerabilidad
| Fecha | Fase | Evento | Detalle |
|---|---|---|---|
| Divulgación | Publicada | GHSA-4VFC-HXPJ-F7X7 divulgada · CVSS 6.5 (GitHub) | |
| Divulgación | Modificada | Última actualización del registro | |
| Monitoreo | Detectada | Ingresó al índice | |
| Monitoreo | Verificada | Última verificación contra las fuentes |
Summary
The nginx `/api/` location in `docker/main/rootfs/usr/local/nginx/conf/nginx.conf` enables `proxy_cache api_cache` with `proxy_cache_valid 200 5s` and no explicit `proxy_cache_key` directive. nginx defaults the cache key to `$scheme$proxy_host$request_uri`, which contains no cookie or `Authorization` header.
`auth_request /auth` runs on every request and validates the JWT signature plus expiry, accepting both admin and viewer tokens as authenticated. nginx then checks the cache before forwarding to FastAPI. On HIT, nginx serves the cached body straight from `/dev/shm/nginx_cache`; the FastAPI route never runs, so route-level `dependencies=[Depends(require_role(["admin"]))]` is skipped.
Any non-admin user with a valid JWT reads the cached admin response within the 5-second window after an admin populates it. This is distinct from GHSA-26g3-f8g8-9ffh, which fixed `/api/config/raw` at the FastAPI dependency level; that fix did not change the nginx cache key, and `/api/config/raw` returns `text/plain` so it never entered the cache.
Result: any authenticated viewer reads admin-only JSON endpoints, including `/api/config/raw_paths` (full RTSP camera URLs with cleartext credentials), `/api/users` (full user and role list), and `/api/recordings/storage`, within 5 seconds of any admin UI poll.
Affected
`ghcr.io/blakeblackshear/frigate:stable` v0.17.1-416a9b7 (current stable as of 2026-05-19). Same code in dev HEAD `d968f00` (no commit since the cache block was introduced changes the cache key).
Default config (`auth.enabled: true` is the default).
Deployments with at least one authenticated non-admin user (viewer role or custom camera-scoped role).
Single-admin Frigate deployments are not affected (no other authenticated principal to receive a cached admin response).
Root cause
`docker/main/rootfs/usr/local/nginx/conf/nginx.conf:247-260`: `location /api/` sets `proxy_cache api_cache` with `proxy_cache_valid 200 5s`; no `proxy_cache_key` directive is set, so nginx uses the default key `$scheme$proxy_host$request_uri` which contains no auth material.
`docker/main/rootfs/usr/local/nginx/conf/nginx.conf:41-44`: `map $sent_http_content_type $should_not_cache { 'application/json' 0; default 1; }` skips cache only for non-JSON responses; every JSON response from FastAPI is cached.
`docker/main/rootfs/usr/local/nginx/conf/auth_request.conf:2`: `auth_request /auth` runs per request and validates the JWT, returning 202 with `Remote-User`/`Remote-Role`; both admin and viewer tokens are accepted as authenticated, and nginx then consults the cache before forwarding to FastAPI.
`frigate/api/app.py:363, 393`: `/api/config/raw_paths` and `/api/config/raw` declare `dependencies=[Depends(require_role(["admin"]))]`; this guard runs inside the FastAPI handler and is bypassed when nginx serves from cache.
`frigate/api/auth.py:870`: `/api/users` declares the same admin-only guard, bypassed under the same condition.
FastAPI does not set a `Cache-Control` response header on `/api/users` or `/api/config/raw_paths`, so nginx considers the response cacheable. The nginx location adds `Cache-Control: no-store` on the response path to the client via `add_header`; this affects the client response only, not nginx's cache decision.
Reproduction
`ghcr.io/blakeblackshear/frigate:stable` (digest `1724960349dad0...`), default config plus two cameras with credentials in the RTSP URL and one viewer-role user.
- Viewer alone hits the admin endpoint and is correctly denied at the FastAPI layer:
GET /api/config/raw_paths HTTP/1.1
Host: target:8971
Cookie: frigate_token=<viewer-jwt>
HTTP/1.1 403 Forbidden
{"detail":"Access denied. A user with the admin role is required."}- Admin populates the nginx cache (the admin UI polls this endpoint while the camera settings page is open):
GET /api/config/raw_paths HTTP/1.1
Host: target:8971
Cookie: frigate_token=<admin-jwt>
HTTP/1.1 200 OK
X-Cache-Status: MISS
{"cameras":{"cam_alpha":{"ffmpeg":{"inputs":[{"path":"rtsp://admin:REAL-PROD-PWD-ALPHA@10.0.0.10:554/main",...- Viewer repeats the identical request within 5 seconds:
GET /api/config/raw_paths HTTP/1.1
Host: target:8971
Cookie: frigate_token=<viewer-jwt>
HTTP/1.1 200 OK
X-Cache-Status: HIT
{"cameras":{"cam_alpha":{"ffmpeg":{"inputs":[{"path":"rtsp://admin:REAL-PROD-PWD-ALPHA@10.0.0.10:554/main",...The same viewer request with header `X-Cache-Bypass: 1` returns 403, confirming the cache layer is the bypass.
Live-verified: viewer-role user reads admin-only `/api/config/raw_paths` and `/api/users` within the 5-second cache window on a fresh `:stable` container.
Impact
- RTSP camera credentials (cleartext `rtsp://user:password@ip:port`) reach the cameras directly and reused on most home IP cameras for the vendor web UI.
- Full user and role enumeration via `/api/users`.
- Storage and operational metrics via `/api/recordings/storage`.
- 13 additional cached endpoints (`/api/events`, `/api/review`, `/api/timeline`, `/api/go2rtc/streams`, `/api/exports`, ...) leak across camera-scope roles.
- One HTTP request, inside the 5-second window after any admin UI poll.
Credit
Jan Kahmen, turingpoint https://turingpoint.de (jan@turingpoint.de).
Desglose de métricas
Rangos afectados
Estado del parche por paquete
| Paquete / producto | Estado | Corregida en | Desde divulgación | Última versión |
|---|---|---|---|---|
pypifrigate |
Sin parche | — | — | 0.7.0 afectada |
Arsenal público
Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.
https://github.com/blakeblackshear/frigate/security/advisories/GHSA-4vfc-hxpj-f7x7Las referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.
