GHSA-6F34-72V5-3CWV
Improper Cookie Attribute Configuration in Authentication Flows (Secure/SameSite Missing)
CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:L/A:N
Fuente: GitHub
Ciclo de vida de la vulnerabilidad
| Fecha | Fase | Evento | Detalle |
|---|---|---|---|
| Divulgación | Publicada | GHSA-6F34-72V5-3CWV divulgada · CVSS 5.4 (GitHub) | |
| Divulgación | Modificada | Última actualización del registro | |
| Monitoreo | Detectada | Ingresó al índice | |
| Monitoreo | Verificada | Última verificación contra las fuentes |
### Summary
OliveTin sets authentication cookies without strong security attributes in login flows. In the tested build (3000.10.0), both local-login and OAuth cookies are issued without Secure and without explicit SameSite in HTTP/backend-non-
TLS conditions. This weakens session protection and can increase risk of session hijacking/replay and cross-site abuse in real deployments (especially internet-facing or proxy/TLS-terminated setups).
### Details
Observed cookie behavior:
- Local login (/api/LocalUserLogin) returns:
- Set-Cookie: olivetin-sid-local=<sid>; Path=/; Max-Age=31556952; HttpOnly
- OAuth login (/oauth/login?provider=github) returns:
- Set-Cookie: olivetin-sid-oauth=<state>; Path=/; Max-Age=900; HttpOnly
In both observed responses:
- Secure flag missing
- SameSite attribute missing
Relevant source locations:
- Local login cookie creation:
- service/internal/api/api.go (LocalUserLogin, cookie fields set without Secure/SameSite)
- OAuth cookie creation:
- service/internal/auth/otoauth2/restapi_auth_oauth2.go (setOAuthCallbackCookie)
- Secure depends on r.TLS != nil, which can be false behind TLS-terminating reverse proxies
- no explicit SameSite attribute
Security classification:
- CWE-614 (Secure attribute not set)
- CWE-1275 (Improper SameSite handling)
### PoC
Tested image:
- ghcr.io/olivetin/olivetin:3000.10.0
- Start OAuth-enabled test instance:
docker rm -f olivetin-secaudit-hash 2>/dev/null || true
docker run -d --name olivetin-secaudit-hash \
-p 1342:1337 \
-v /home/kali/CVE/OliveTin/lab-config:/config:ro \
ghcr.io/olivetin/olivetin:3000.10.0- Generate a valid password hash:
curl -sS -X POST http://127.0.0.1:1342/api/PasswordHash \
-H 'Content-Type: application/json' \
--data '{"password":"SecretPass123!"}'- Create local-auth config using returned hash and run local-auth instance:
OliveTin/lab-config-localauth/config.yaml <<'YAML'
listenAddressSingleHTTPFrontend: 0.0.0.0:1337
logLevel: "DEBUG"
checkForUpdates: false
authRequireGuestsToLogin: true
authLocalUsers:
enabled: true
users:
- username: "alice"
usergroup: "admin"
password: "<PASTE_HASH_HERE>"
actions:
- title: noop
shell: echo "ok"
YAML
docker run -d --name olivetin-secaudit-auth \
-p 1343:1337 \
-v /home/kali/CVE/OliveTin/lab-config-localauth:/config:ro \
ghcr.io/olivetin/olivetin:3000.10.0- Confirm local login cookie flags:
curl -i -X POST http://127.0.0.1:1343/api/LocalUserLogin \
-H 'Content-Type: application/json' \
--data '{"username":"alice","password":"SecretPass123!"}'Observed:
- Set-Cookie: olivetin-sid-local=...; Path=/; Max-Age=...; HttpOnly
- no Secure, no SameSite- Confirm OAuth cookie flags:
curl -i "http://127.0.0.1:1342/oauth/login?provider=github"
Observed:
- Set-Cookie: olivetin-sid-oauth=...; Path=/; Max-Age=900; HttpOnly
- no explicit SameSite, no Secure in this HTTP flow
```bash
6. Replay impact demonstration:
curl -c /tmp/ot_cookie.txt -sS -X POST http://127.0.0.1:1343/api/LocalUserLogin \
-H 'Content-Type: application/json' \
--data '{"username":"alice","password":"SecretPass123!"}' >/dev/null
curl -i -X POST http://127.0.0.1:1343/api/WhoAmI \
-H 'Content-Type: application/json' \
--data '{}'
curl -i -b /tmp/ot_cookie.txt -X POST http://127.0.0.1:1343/api/WhoAmI \
-H 'Content-Type: application/json' \
--data '{}'
Observed:
- first call returns 403 (guest)
- second call returns 200 authenticated as alice olivetin_cookie_validation.log
== LocalUserLogin headers ==
HTTP/1.1 200 OK
Accept-Encoding: gzip
Content-Type: application/json
Set-Cookie: olivetin-sid-local=227001f8-6646-40d2-81ca-cb57ad18c567; Path=/; Max-Age=31556952; HttpOnly
Date: Thu, 26 Feb 2026 15:12:27 GMT
Content-Length: 16
{"success":true}
== OAuth login headers ==
HTTP/1.1 302 Found
Content-Type: text/html; charset=utf-8
Location: https://github.com/login/oauth/authorize?client_id=test-client-id&redirect_uri=http%3A%2F%2F127.0.0.1%3A1337%2Foauth%2Fcallback&response_type=code&scope=read%3Auser+user%3Aemail&state=yKBUWZEENUbKR1SwrXMsPA%3D%3D
Set-Cookie: olivetin-sid-oauth=yKBUWZEENUbKR1SwrXMsPA==; Path=/; Max-Age=900; HttpOnly
Date: Thu, 26 Feb 2026 15:12:27 GMT
Content-Length: 251
<a href="https://github.com/login/oauth/authorize?client_id=test-client-id&redirect_uri=http%3A%2F%2F127.0.0.1%3A1337%2Foauth%2Fcallback&response_type=code&scope=read%3Auser+user%3Aemail&state=yKBUWZEENUbKR1SwrXMsPA%3D%3D">Found</a>.
== WhoAmI without cookie ==
HTTP/1.1 403 Forbidden
Accept-Encoding: gzip
Content-Type: application/json
Date: Thu, 26 Feb 2026 15:12:27 GMT
Content-Length: 87
{"code":"permission_denied","message":"guests are not allowed to access the dashboard"}
== WhoAmI with cookie ==
HTTP/1.1 200 OK
Accept-Encoding: gzip
Content-Type: application/json
Date: Thu, 26 Feb 2026 15:12:27 GMT
Content-Length: 127
{"authenticatedUser":"alice", "usergroup":"admin", "provider":"local", "acls":[], "sid":"d730c6df-0a7a-414a-b079-2c59113a6eeb"}### Impact
This is an authentication/session hardening vulnerability (cookie security misconfiguration), not direct RCE/auth bypass by itself.
Who is impacted:
- OliveTin deployments exposed over HTTP
- Deployments behind TLS-terminating reverse proxies where backend requests are non-TLS
- Environments relying on strong cookie-level CSRF/session protections
Practical risk:
- Increased chance of session token theft/replay
- Weaker cross-site request/session isolation due missing explicit SameSite
- Severity is typically deployment-dependent (commonly low/medium) but meaningful for production security posture
Incluye detalles técnicos publicados por el investigador. Úselos solo para validar y corregir sus propios sistemas.
Desglose de métricas
Versiones afectadas
3000.10.0Estado del parche por paquete
| Paquete / producto | Estado | Corregida en | Desde divulgación | Última versión |
|---|---|---|---|---|
Gogithub.com/OliveTin/OliveTin |
Sin parche | — | — | — |
Arsenal público
Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.
https://github.com/OliveTin/OliveTin/security/advisories/GHSA-6f34-72v5-3cwvLas referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.
