GHSA-FHM7-PF6P-PRGG
Inverted Admin Authorization Check Renders 13 Critical Admin Functions Permanently Inaccessible
CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:U/C:N/I:H/A:H
Fuente: GitHub
Ciclo de vida de la vulnerabilidad
| Fecha | Fase | Evento | Detalle |
|---|---|---|---|
| Divulgación | Publicada | GHSA-FHM7-PF6P-PRGG divulgada · CVSS 6.5 (GitHub) | |
| Monitoreo | Detectada | Ingresó al índice | |
| Monitoreo | Verificada | Última verificación contra las fuentes |
### Summary
In `app/sources/admin.queries.php`, 13 `switch` cases use an inverted authorization guard: `if ($session->get('user-admin') === 1) { error; break; }`. The intended logic is `!== 1` (deny non-admins), but the condition `=== 1` instead denies only administrators. Because the outer page-access gate correctly restricts the file to admin users only, no non-admin user can reach these cases — but the inverted check then blocks admins from executing them either. The result is that these operations are permanently inaccessible to all users.
### Details
`app/sources/admin.queries.php:72` — Outer gate requires admin:
if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('admin') === false) {
exit; // only admin=1 users pass
}`app/sources/admin.queries.php:125` — Inverted inner guard (representative of all 13 instances):
// Is admin?
if ($session->get('user-admin') === 1) { // BUG: should be !== 1
echo prepareExchangedData(['error' => true, 'message' => $lang->get('error_not_allowed_to')], 'encode');
break;
}
// ... actual backup code unreachable for every user ...Full list of blocked cases: `admin_action_db_backup` (line 112), `admin_action_db_restore` (line 235), `admin_action_db_optimize` (line 326), `admin_action_reload_cache_table` (line 422), `admin_action_change_salt_key___start/encrypt/end/restore_backup/delete_backup` (lines 474–1109), `admin_action_attachments_cryption` / `admin_action_attachments_cryption_continu` (lines 1358–1556), `admin_action_api_save_key` (line 1556), `admin_action_api_save_ip` (line 1647).
PoC
# Trigger as admin user — receives 'error_not_allowed_to' instead of running backup:
POST /app/sources/admin.queries.php HTTP/1.1
Cookie: <admin_session>
type=admin_action_db_backup&key=<session_key>
# Response: {"error":true, "message":"You are not allowed to do this!"}### Impact
Critical administrative functions — including all database backups/restores, encryption key (salt) rotation, cache rebuilding, and API key management — are permanently broken in the GUI for all administrators. Organizations relying on these functions for disaster recovery or compliance are directly impacted. Note: this is not exploitable by non-admin users to gain access; the outer gate remains correct.
### Fix
Change all 13 instances of `if ($session->get('user-admin') === 1)` to `if ($session->get('user-admin') !== 1)` in `app/sources/admin.queries.php` (lines 125, 248, 339, 435, 487, 608, 991, 1042, 1122, 1371, 1445, 1569, 1660).
If possible, please apply for a CVE number when posting.
Incluye detalles técnicos publicados por el investigador. Úselos solo para validar y corregir sus propios sistemas.
Desglose de métricas
Rangos afectados
Estado del parche por paquete
| Paquete / producto | Estado | Corregida en | Desde divulgación | Última versión |
|---|---|---|---|---|
Packagistnilsteampassnet/teampass |
Sin parche | — | — | — |
Arsenal público
Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.
https://github.com/nilsteampassnet/TeamPass/security/advisories/GHSA-fhm7-pf6p-prggLas referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.
