GHSA-G2XH-C426-V8MF
Vyper: reversed order of side effects for some operations
Ciclo de vida de la vulnerabilidad
| Fecha | Fase | Evento | Detalle |
|---|---|---|---|
| Divulgación | Publicada | GHSA-G2XH-C426-V8MF divulgada | |
| Remediación | Parche 0.4.3 | vyper · 653 d desde divulgación | |
| Divulgación | Modificada | Última actualización del registro | |
| Monitoreo | Detectada | Ingresó al índice |
Impact
For the following (probably non-exhaustive) list of expressions, the compiler evaluates the arguments from right to left instead of left to right.
- unsafe_add
- unsafe_sub
- unsafe_mul
- unsafe_div
- pow_mod256
- |, &, ^ (bitwise operators)
- bitwise_or (deprecated)
- bitwise_and (deprecated)
- bitwise_xor (deprecated)
- raw_call
- <, >, <=, >=, ==, !=
- in, not in (when lhs and rhs are enums)This behaviour becomes a problem when the evaluation of one of the arguments produces side effects that other arguments depend on. The following expressions can produce side-effect:
- state modifying external call
- state modifying internal call
- `raw_call`
- `pop()` when used on a Dynamic Array stored in the storage
- `create_minimal_proxy_to`
- `create_copy_of`
- `create_from_blueprint`
For example:
f:uint256
@internal
def side_effect() -> uint256:
self.f = 12
return 1
@external
def foo() -> uint256:
return unsafe_add(self.f,self.side_effect()) # returns 13 instead of 1a:DynArray[uint256, 12]
@external
def bar() -> bool:
self.a = [1,2,3]
return len(self.a) == self.a.pop() # return false instead of true### Patches
not yet patched, will address in a future release. tracking in https://github.com/vyperlang/vyper/issues/3604.
Workarounds
When using expressions from the list above, make sure that the arguments of the expression do not produce side effects or, if one does, that no other argument is dependent on those side effects.
### References
_Are there any links users can visit to find out more?_
Rangos afectados
Estado del parche por paquete
| Paquete / producto | Estado | Corregida en | Desde divulgación | Última versión |
|---|---|---|---|---|
pypivyper |
Corregida | 0.4.3 | 653 d | 0.4.3 no afectada |
0.4.3Arsenal público
Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.
https://nvd.nist.gov/vuln/detail/CVE-2023-40015https://github.com/vyperlang/vyper/security/advisories/GHSA-g2xh-c426-v8mfhttps://github.com/vyperlang/vyper/issues/3604https://github.com/vyperlang/vyper/issues/4019https://github.com/vyperlang/vyper/pull/4157https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2023-167.yamlhttps://github.com/vyperlang/vyperLas referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.
