llamaCVEVulnerability Intelligence
/
Advisory · GitHub · PyPI · vyper

GHSA-MR6R-MVW4-736G

Vyper interfaces returning integer types less than 256 bits can be manipulated if uint256 is used

Parche disponible
Descargar PNG JSON
CVSS
—
low
Fuente: —
ExplotaciónSin evidenciaNo figura en CISA KEV
Exploits públicos0Ninguno conocido
Parche1 versiónPrimer parche a 100 d de la divulgación
Exposición2.430 dDesde la divulgación, 25 mar 2020, 1:20 p. m.
Detección2.427 dDesde la divulgación hasta su ingreso al índice
Timeline

Ciclo de vida de la vulnerabilidad

Hoy
Divulgación
Publicada
Modificada
Explotación
Remediación
Parche 0.2.1
Monitoreo
Detectada
25 mar 20
3 jul 20
24 oct 26
17 nov 26
20 nov 26
25 mar 20
23 nov 21
23 jul 23
22 mar 25
20 nov 26
FechaFaseEventoDetalle
Divulgación Publicada GHSA-MR6R-MVW4-736G divulgada
Remediación Parche 0.2.1 vyper · 100 d desde divulgación
Divulgación Modificada Última actualización del registro
Monitoreo Detectada Ingresó al índice
Resumen
Descripción del advisory
Texto original · GitHub · en inglés

VVE-2020-0001

Earlier today, we received a responsible disclosure of a potential issue from @montyly (security researcher at @trailofbits) for Vyper users who make assumptions about what values certain interface types can return.

### Impact
We determined the issue to be mild and unlikely to be exploited, with an easy workaround while the correct resolution is in process. The issue stems from a number of things, which we will detail here.

(1) The ABI Specification is under-defined such that function return type is not always reflected in how you use it

This means that a function which returns `uint8` under the hood actually returns a 32 byte integer, making it identical to a function that returns `uint256`. This allows users to read an interface that returns a `uint8` value to be stored into a `uint256` variable without any explicit casting or input validation.

(2) Vyper doesn't have `uint8` types

When Vyper was originally created, it only had one numeric type, but we added just enough types to be able to work with the majority of ERC interfaces that exist.

Unfortunately, we never added `uint8`, because it's only majority usage was for `ERC20.decimals()` as the return type, which isn't reflected in the method ID. Because of (1), it didn't matter that we didn't have these types implemented because you could capture the return value as `uint256` and use it just fine.

(3) `ERC20.decimals()` returns `uint8`

`ERC20.decimal()` (which is an optional function) returns a `uint8` type. While it was never intentioned to be used directly within a smart contract (hence being optional), someone could easily make the decision to rely on it to perform important functionality within their Vyper smart contract. This might lead to a scenario where an unexpectedly large value (> 255) returned by calling this function (which a malicious contract writer might write) would allow an attacker to manipulate or bypass certain logic depending on this value.

In summary, because of (1), it isn't necessary to have to cast the return value of a function that returns `uint8` to `uint256`, and because of (2) it isn't possible to have the type system protect against this type of error. This could lead to scenarios like (3) where this behavior can be exploited.

### Patches
We are currently refactoring our typing system so we can implement all ABI-compliant integer types, but no currently patched version is available that gives users access to the `uint8` type.

### Workarounds
There is an easy workaround where you should check that the value returned by an interface which specifies `uint8` should be checked to be within the bounds of a `uint8` integer. As an example:

...
# returns uint8, but we implicitly cast to uint256 without checking
decimals: uint256 = ERC20(_token).decimal()
# FIX: Insert this line
assert decimals < 256
...

Depending on how you use this value, it may not be necessary to insert this check.

### References
* ABI Specification https://solidity.readthedocs.io/en/latest/abi-spec.html

### For more information
If you have any questions or comments about this advisory:
* Chat with us in our gitter https://gitter.im/vyperlang/community
* Open an issue in https://github.com/vyperlang/vyper https://github.com/vyperlang/vyper
* Email us at [security@vyperlang.org](mailto:security@vyperlang.org)

Incluye detalles técnicos publicados por el investigador. Úselos solo para validar y corregir sus propios sistemas.

Versiones

Rangos afectados

Afectada Corregida Última
vyper≤ 0.1.0b16
0.1.0b16
0.4.3
Remediación

Estado del parche por paquete

Paquete / productoEstadoCorregida enDesde divulgaciónÚltima versión
pypivyper
Corregida 0.2.1 100 d 0.4.3 no afectada
Versiones corregidas0.2.1
Explotación

Arsenal público

Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.

Referencias
Otrahttps://github.com/vyperlang/vyper/security/advisories/GHSA-mr6r-mvw4-736g

Las referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.