GHSA-RGG9-956J-3378
Mareforma: invalidated claims still promote to REPLICATED
Ciclo de vida de la vulnerabilidad
| Fecha | Fase | Evento | Detalle |
|---|---|---|---|
| Divulgación | Publicada | GHSA-RGG9-956J-3378 divulgada | |
| Divulgación | Modificada | Última actualización del registro | |
| Monitoreo | Detectada | Ingresó al índice | |
| Monitoreo | Verificada | Última verificación contra las fuentes |
What's wrong
`_maybe_update_replicated_unlocked` never checks `t_invalid`, so a claim that a signed contradiction verdict has marked invalid can still climb to REPLICATED through convergence detection, and it pulls an honest peer up with it.
Three gaps line up:
- The new-claim short-circuit reads only `status` and `asserter_keyid` (`core.py:1339-1352`); an invalidated but still-`open` new claim passes.
- The candidate-peer SELECT filters `status = 'open'`, `unresolved = 0`, and `transparency_logged = 1` but has no `t_invalid` predicate (`core.py:1390-1410`), so an invalidated existing claim qualifies as a convergence partner.
- The promotion UPDATE gates only on `status = 'open'` (`core.py:1422-1426`), leaving a TOCTOU window even after the SELECT is fixed.
A signed contradiction verdict is meant to be terminal for the trust ladder: `validate_claim` refuses to promote a `t_invalid` claim to ESTABLISHED, and `record_replication_verdict` already gates its promotion UPDATE on `t_invalid IS NULL`. Convergence promotion is the one path that ignores the verdict. Reproduced at runtime: contradict claim X (t_invalid set, still PRELIMINARY), then assert peer Y sharing X's ESTABLISHED anchor; both X and Y land at REPLICATED, with X's `t_invalid` still set.
Severity and impact
High. A refuted claim re-enters the trust ladder at REPLICATED after its contradiction, and it serves as the corroborating peer that promotes an honest claim. Both outcomes contradict the documented refutation model, and REPLICATED is the input to further validation.
Location
- `mareforma/db/core.py:1339` new-claim short-circuit checks `status` and `asserter_keyid` but not `t_invalid`
- `mareforma/db/core.py:1390` candidate-peer SELECT WHERE clause has no `t_invalid IS NULL` predicate
- `mareforma/db/core.py:1422` promotion UPDATE gates on `status = 'open'` only, reopening the window between SELECT and UPDATE
Fix direction
Treat `t_invalid` the way the neighboring code already does. Extend the new-claim short-circuit to also read `t_invalid` and return when it is set. Add `AND c.t_invalid IS NULL` to the candidate-peer SELECT. Add `AND t_invalid IS NULL` to the promotion UPDATE's WHERE clause so the row-level lock closes the TOCTOU window, matching the gate `record_replication_verdict` already applies at `core.py:3539`.
Do red/green TDD: add a regression test that fails on `main`, then make it pass.
Quality bar
SOLID, DRY, KISS. Clean, readable, well-tested code. No new errors, warnings, or test failures; the full suite stays green on all supported Python versions.
Rangos afectados
Estado del parche por paquete
| Paquete / producto | Estado | Corregida en | Desde divulgación | Última versión |
|---|---|---|---|---|
PyPImareforma |
Corregida | 0.3.8 | — | — |
0.3.8Arsenal público
Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.
https://nvd.nist.gov/vuln/detail/CVE-2026-71500https://github.com/mareforma/mareforma/security/advisories/GHSA-rgg9-956j-3378https://github.com/mareforma/mareforma/pull/58https://github.com/mareforma/mareforma/commit/c9d8922132d916e4fd013890cb4e17921e00065ehttps://github.com/mareforma/mareformahttps://github.com/mareforma/mareforma/releases/tag/v0.3.8Las referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.
