GHSA-VF85-8FF2-3R9W
django-filer: Missing per-object authorization on `discard` and `edit_redirect` version transitions
CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:N/I:L/A:N
Fuente: GitHub
Ciclo de vida de la vulnerabilidad
| Fecha | Fase | Evento | Detalle |
|---|---|---|---|
| Remediación | Parche 3.5.0 | django-filer · -135 d desde divulgación | |
| Divulgación | Publicada | GHSA-VF85-8FF2-3R9W divulgada · CVSS 4.3 (GitHub) | |
| Monitoreo | Detectada | Ingresó al índice | |
| Divulgación | Modificada | Última actualización del registro | |
| Monitoreo | Fuente: GitHub Security Advisories | Registro visto por primera vez en GitHub Security Advisories | |
| Monitoreo | Fuente: OSV | Registro visto por primera vez en OSV | |
| Monitoreo | Verificada | Última verificación contra las fuentes |
Summary
When django-filer's optional per-folder permission system is enabled (`FILER_ENABLE_PERMISSIONS=True`), the "Delete files and/or folders" admin action does not enforce per-folder edit permissions the way every other mutating action does. A staff user who is scoped read-only on a folder via `FolderPermission` (`can_edit = DENY`), but who holds the global Django model-level `delete_*` permission, can delete files and entire subfolders inside that folder — even though their move, rename, copy, and resize actions on the same folder are correctly denied.
This is an integrity / edit-control gap (unauthorized deletion). It is not a read-confidentiality issue: filer files are world-downloadable by design, so no confidentiality claim is made.
Affected versions
- django-filer `<= 3.4.4` (verified end-to-end on 3.4.4 and on `master` prior to the fix).
Only installations running with `FILER_ENABLE_PERMISSIONS = True` (the optional per-folder `FolderPermission` system) are affected. Deployments that leave permissions disabled (the default) rely solely on Django model-level permissions and are not impacted by this specific gap.
Patched versions
- Fixed in PR #1605
https://github.com/django-cms/django-filer/pull/1605. Upgrade to the first release containing that commit (`3.5.0` or later).
Details
The `delete_files_or_folders` admin action in `filer/admin/folderadmin.py` authorized deletion using only:
- `self.has_delete_permission(request)` — which returns `True` for `obj=None`, and
- the Django model-level `delete_file` / `delete_folder` / `delete_image` permission (enforced downstream by the admin delete machinery).
It never called `check_folder_edit_permissions` or `check_files_edit_permissions`. Every sibling mutating action — move, rename, copy, resize — *does* call these helpers, which walk the selected objects (and their descendants) and enforce the per-folder `can_edit` grant from `FolderPermission`.
Because `FolderPermission` has no dedicated `can_delete` field, deletion is treated as an edit/management operation and is gated elsewhere on `can_edit`. The delete action's omission therefore let a folder-scoped read-only user bypass the per-folder control that constrains all their other write operations.
Precondition
The attacker must hold the Django model-level `delete_file` / `delete_folder` / `delete_image` permission. A purely read-only user (no model-level delete perm) receives `403` and cannot exploit this. This precondition matches the standard folder-scoped-staff deployment model, where staff hold model-level permissions and are further constrained per-folder by `FolderPermission`.
Mitigation
- Upgrade to the patched release.
- Until upgrading, avoid granting the model-level `delete_file` /
Credit
Reported through coordinated disclosure. Fixed in PR #1605.
Incluye detalles técnicos publicados por el investigador. Úselos solo para validar y corregir sus propios sistemas.
Desglose de métricas
Rangos afectados
Estado del parche por paquete
| Paquete / producto | Estado | Corregida en | Desde divulgación | Última versión |
|---|---|---|---|---|
pypidjango-filer |
Corregida | 3.5.0 | -135 d | 3.6.0 no afectada |
3.5.0Arsenal público
Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.
https://github.com/django-cms/django-filer/security/advisories/GHSA-vf85-8ff2-3r9whttps://github.com/django-cms/django-filer/pull/1605https://github.com/django-cms/django-filer/commit/29d20ec0de13d7f77fa2cea93166f8d50a3f508dhttps://github.com/django-cms/django-filer/commit/742ba4c3094dd75e586ca3a05e6ad2703de4553bhttps://github.com/django-cms/django-filerhttps://github.com/django-cms/django-filer/releases/tag/3.5.0Las referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.
