GHSA-XF36-WX48-5RQP
Google SSO accepts deactivated users (activated flag not enforced on Google auth path)
Ciclo de vida de la vulnerabilidad
| Fecha | Fase | Evento | Detalle |
|---|---|---|---|
| Divulgación | Publicada | GHSA-XF36-WX48-5RQP divulgada | |
| Monitoreo | Detectada | Ingresó al índice | |
| Monitoreo | Verificada | Última verificación contra las fuentes |
Summary
`GoogleAuthController::handleGoogleCallback` looked up the local Snipe-IT user with `User::where('username', $socialUser->getEmail())->first()` and called `Auth::login($user, true)` if the lookup returned a row. Every other authentication path in Snipe-IT (SAML, LDAP, REMOTE_USER, local-password) enforced `activated = 1` in its lookup. The Google path did not.
Under specific conditions (Google SSO enabled, deployment uses email-as-username or a specific account has an email-shaped username, and the user has been deactivated in Snipe-IT with `activated = 0` but the Google identity is still live), the deactivated user could sign in via Google and obtain an authenticated session at their original permission level.
Impact
The offboarding window between deactivating a user in Snipe-IT and revoking their Google Workspace identity became an authentication bypass window. A deactivated user with still-live Google credentials could re-authenticate to Snipe-IT at their original permission tier, including `admin` if applicable.
Default Snipe-IT installations use the `firstname.lastname` username format and were not affected even with Google SSO enabled: the username / email mismatch caused the lookup to return `NULL`.
Affected
- `app/Http/Controllers/GoogleAuthController.php::handleGoogleCallback`
Affected versions: `<= 8.6.2`.
Fix
Fixed in commit `5fea2fadc0`. The controller now checks `if (! $user->activated)` after the lookup and redirects with `auth/message.account_not_activated` rather than calling `Auth::login`. Functionally equivalent to adding `->where('activated', '=', '1')` on the query.
Patched in `8.6.3` and later.
References
- CWE-285 (Improper Authorization)
- CWE-287 (Improper Authentication)
Estado del parche por paquete
La fuente no informa paquetes ni versiones corregidas.
Arsenal público
Sin exploits, módulos ni PoC públicos conocidos a la fecha de verificación.
https://github.com/grokability/snipe-it/security/advisories/GHSA-xf36-wx48-5rqpLas referencias externas se muestran para copiar: cve.llama.ec no lo redirige a otros sitios.
